Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error message from psycopg2 using to_native #32371

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Handle error message from psycopg2 using to_native #32371

merged 1 commit into from
Nov 1, 2017

Conversation

Akasurde
Copy link
Member

SUMMARY

This fix adds handling of error/exception message using
to_native API instead of decoding.
Also, fixes PEP8 errors.

Fixes: #31825

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/database/postgresql/postgresql_privs.py
test/sanity/pep8/legacy-files.txt

ANSIBLE VERSION
2.5-devel

@Akasurde
Handle error message from psycopg2 using to_native
47ed797 
This fix adds handling of error/exception message using
to_native API instead of decoding.
Also, fixes PEP8 errors.

Fixes: ansible#31825

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This was referenced Oct 31, 2017
Closed
Closed
@ansibot
Copy link
Contributor

ansibot commented Oct 31, 2017

cc @b6d @matburt
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Oct 31, 2017
@Akasurde
Copy link
Member Author

ready_for_review

@resmo
Copy link
Contributor

resmo commented Nov 1, 2017

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Nov 1, 2017
@ansibot ansibot merged commit 51c5b51 into ansible:devel Nov 1, 2017
@Akasurde
Copy link
Member Author

Akasurde commented Nov 2, 2017

@resmo Thanks for review and merge.

@Akasurde Akasurde deleted the i31825 branch November 2, 2017 00:59
@Akasurde Akasurde mentioned this pull request Feb 26, 2018
Closed
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the postgresql PostgreSQL community label Feb 1, 2019
@dagwieers dagwieers added the database Database category label Feb 13, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. database Database category module This issue/PR relates to a module. postgresql PostgreSQL community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

postgredsql_privs lost error message if failed in SQL level
4 participants
@Akasurde @ansibot @resmo @dagwieers