Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ec2_ami_find #32501

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Deprecate ec2_ami_find #32501

merged 1 commit into from
Nov 9, 2017

Conversation

prasadkatti
Copy link
Contributor

SUMMARY

Deprecate ec2_ami_find module. The new module ec2_ami_facts should be used instead.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ec2_ami_find

ANSIBLE VERSION
ansible 2.5.0

@prasadkatti prasadkatti mentioned this pull request Nov 2, 2017
Merged
@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:306:24: E231 missing whitespace after ','
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:322:14: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:322:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:323:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:323:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:324:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:324:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:325:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:325:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:325:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:326:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:326:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:327:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:327:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:328:18: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:328:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:329:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:329:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:330:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:330:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:331:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:331:23: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:332:13: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:332:15: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:335:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:335:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:336:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:336:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:337:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:338:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:338:21: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:339:17: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:339:19: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:340:14: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:340:16: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:341:28: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:341:30: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:342:25: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:342:27: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:343:17: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:343:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:343:26: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:382:26: E226 missing whitespace around arithmetic operator
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:438:76: E225 missing whitespace around operator
lib/ansible/modules/cloud/amazon/_ec2_ami_find.py:440:64: E225 missing whitespace around operator
test/sanity/pep8/legacy-files.txt:14:1: A101 Remove "lib/ansible/modules/cloud/amazon/ec2_ami_find.py" since it does not exist

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2017

cc @willthames
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws ci_verified Changes made in this PR are causing tests to fail. cloud docs_pull_request module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 2, 2017
@ansibot ansibot added test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels Nov 2, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 2, 2017

@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Lujeni @MichaelBaydoun @Sodki @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @carsongee @defunctio @dkhenry @fiunchinho @garethr @gunzy83 @gurumaia @hyperized @infectsoldier @j-carl @jarv @Java1Guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @MichaelBaydoun @michaeljs1990 @minichate @mjschultz @mmochan @nadirollo @nand0p @naslanidis @NickBall @pjodouin @psykotox @pwnall @raags @rickmendes @roadmapper @ryansydnor @scicoin-project @scottanderson42 @shepdelacreme @silviud @simplesteph @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @whiter @wilvk @wimnat @zacblazic @zbal @zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 2, 2017
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Nov 2, 2017
@Sodki
Copy link
Contributor

Sodki commented Nov 7, 2017

@prasadkatti This looks good. Can you resolve the conflicts, please?

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 7, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 7, 2017

@prasadkatti this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added the merge_commit This PR contains at least one merge commit. Please resolve! label Nov 7, 2017
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Nov 7, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 7, 2017
@prasadkatti
Copy link
Contributor Author

ready_for_review

@Sodki
Copy link
Contributor

Sodki commented Nov 8, 2017

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 8, 2017
@willthames willthames merged commit 306c350 into ansible:devel Nov 9, 2017
@willthames
Copy link
Contributor

Merged, thanks @prasadkatti

@prasadkatti prasadkatti deleted the deprecate-ec2_ami_find branch November 9, 2017 02:06
@aioue aioue mentioned this pull request Dec 20, 2017
Closed
@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed docs_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws cloud docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. new_module This PR includes a new module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prasadkatti @ansibot @Sodki @willthames @nitzmahone