Lock azure-mgmt-containerservice to 1.0.0. #32518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to create an Azure Container Service cluster results in an exception, apparently because the API of `azure.mgmt.containerservice.models.ContainerServiceMasterProfile` changed in 2.0.0:
```
Traceback (most recent call last):
File "/var/folders/80/3373r54x51x__g9svfyxbr1c0000gn/T/ansible_rqtXta/ansible_module_azure_rm_acs.py", line 719, in <module>
main()
File "/var/folders/80/3373r54x51x__g9svfyxbr1c0000gn/T/ansible_rqtXta/ansible_module_azure_rm_acs.py", line 716, in main
AzureRMContainerService()
File "/var/folders/80/3373r54x51x__g9svfyxbr1c0000gn/T/ansible_rqtXta/ansible_module_azure_rm_acs.py", line 513, in __init__
supports_tags=True)
File "/var/folders/80/3373r54x51x__g9svfyxbr1c0000gn/T/ansible_rqtXta/ansible_modlib.zip/ansible/module_utils/azure_rm_common.py", line 256, in __init__
File "/var/folders/80/3373r54x51x__g9svfyxbr1c0000gn/T/ansible_rqtXta/ansible_module_azure_rm_acs.py", line 617, in exec_module
self.results['state'] = self.create_update_acs()
File "/var/folders/80/3373r54x51x__g9svfyxbr1c0000gn/T/ansible_rqtXta/ansible_module_azure_rm_acs.py", line 652, in create_update_acs
master_profile=create_master_profile_instance(self.master_profile),
File "/var/folders/80/3373r54x51x__g9svfyxbr1c0000gn/T/ansible_rqtXta/ansible_module_azure_rm_acs.py", line 328, in create_master_profile_instance
dns_prefix=masterprofile[0]['dns_prefix']
TypeError: __init__() takes at least 3 arguments (3 given)
```
Locking the dependency to 1.0.0 solves the error until the module can be updated to the new API.
ansibot
added
affects_2.5
|
The test |
ansibot
added
the
needs_revision
nitzmahone
added a commit
that referenced
this pull request
Nov 2, 2017
* supersedes/fixes #32518 * only for 2.4.x - we'll make the necessary code changes for 2.5 to work with the updated version
|
Thanks- committed via 82c2da3 for 2.4.2rc1 - will look into proper fix for 2.5. |
s-hertel
removed
the
needs_triage
kiorky
pushed a commit
to corpusops/ansible
that referenced
this pull request
Nov 6, 2017
* supersedes/fixes ansible#32518 * only for 2.4.x - we'll make the necessary code changes for 2.5 to work with the updated version
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Attempting to create an Azure Container Service cluster results in an exception, apparently because the API of
azure.mgmt.containerservice.models.ContainerServiceMasterProfilechanged in 2.0.0:Locking the dependency to 1.0.0 solves the error until the module can be updated to the new API.
ISSUE TYPE
COMPONENT NAME
azure_rm_acs
ANSIBLE VERSION