eos_static_route DI module #32587
Merged
eos_static_route DI module #32587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishnaguha
force-pushed
the
eos_static_route
branch
from
2b27b41
to
4b8f4e4
Compare
ansibot
added
affects_2.5
trishnaguha
force-pushed
the
eos_static_route
branch
from
4b8f4e4
to
e993ed4
Compare
trishnaguha
added
support:network
ansibot
added
community_review
trishnaguha
force-pushed
the
eos_static_route
branch
from
0736b66
to
02131aa
Compare
trishnaguha
force-pushed
the
eos_static_route
branch
from
0da74e5
to
6e6144e
Compare
kedarkekan
suggested changes
Nov 7, 2017
| @@ -0,0 +1,102 @@ | |||
| --- | |||
| - name: setup - remove config used in test | |||
There was a problem hiding this comment.
These are same tests as above cli/basic.yaml?
There was a problem hiding this comment.
Yeah same test. but for platform agnostic net_static_route.
| supports_check_mode=True) | ||
|
|
||
| warnings = list() | ||
| check_args(module, warnings) |
There was a problem hiding this comment.
Verifying here that IP address and prefix are in correct format would be good.
Look for APIs:
socket.inet_pton(socket.AF_INET, address) and socket.inet_pton(socket.AF_INET6, address)
ansibot
added
needs_revision
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
eos_static_route
branch
2 times, most recently
from
8d03c43
to
a9cccb2
Compare
trishnaguha
added
support:network
kedarkekan
approved these changes
Nov 7, 2017
ansibot
added
support:community
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
eos_static_route
branch
from
a9cccb2
to
3d7a2b0
Compare
ansibot
removed
the
ci_verified
1 task
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
eos_static_route DI module #31299
Integration test
ISSUE TYPE
COMPONENT NAME
module_utils/network_common
modules/network/eos/eos_static_route
test/integration/targets/eos_static_route/*
test/integration/targets/net_static_route/*
ANSIBLE VERSION