Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mtu option nxos_interface feature idea #32680

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Add mtu option nxos_interface feature idea #32680

merged 2 commits into from
Nov 13, 2017

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Nov 8, 2017 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #26162
Add mtu option nxos_interface feature idea

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/network/nxos/nxos_interface
test/units/module/network/nxos/test_nxos_interface
test/units/module/network/nxos/fixtures/nxos_interface/

ANSIBLE VERSION
2.5

@ansibot
Copy link
Contributor

ansibot commented Nov 8, 2017

cc @GGabriele @jedelman8 @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Nov 8, 2017
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Nov 8, 2017
@trishnaguha trishnaguha added this to the 2.5.0 milestone Nov 8, 2017
Qalthos
Qalthos suggested changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for MTU parameter?

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. owner_pr This PR is made by the module's maintainer. labels Nov 8, 2017
@trishnaguha
Copy link
Member Author

@Qalthos pushed the test.

@ansibot
Copy link
Contributor

ansibot commented Nov 10, 2017

cc @ganeshrn @gundalow
click here for bot help

@ansibot ansibot added the test This PR relates to tests. label Nov 10, 2017
@trishnaguha trishnaguha force-pushed the nxos_interface_mtu_option branch 4 times, most recently from 0b3907d to 5f9373f Compare November 10, 2017 06:16
@trishnaguha
Add mtu option nxos_interface feature idea
2c578e8 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
Add unit test for mtu feature
4428e58 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 13, 2017
@trishnaguha trishnaguha merged commit e4052c1 into ansible:devel Nov 13, 2017
@trishnaguha trishnaguha deleted the nxos_interface_mtu_option branch November 13, 2017 14:48
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

mtu and interface parameter not available on nxos_system
4 participants
@trishnaguha @ansibot @Qalthos @dagwieers