Fix ios_config file prompt issue

[ganeshrn]

SUMMARY

Fixes #23263

Add a carriage return (\r) at end of copy config
the command which results in prompt on cli terminal

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ios_config

ANSIBLE VERSION

2.5

ADDITIONAL INFORMATION

[ansibot]

cc @Qalthos @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

[ganeshrn]

@privateip Thank you!

[termlen0]

Any chance this can be pushed in through a minor release? Mainly because the deprecation warning is confusing while using the deprecated save parameter:
[DEPRECATION WARNING]: Param 'save' is deprecated. See the module docs for more information. This feature will be removed in version 2.4.

Obviously the deprecated method works in 2.4....

[gundalow]

@termlen0 the comment you've added doesn't seem to be related to the code in this PR. Could you please raise a separate issue? Thanks in advance.

[termlen0]

@gundalow I can. This is the fix however. Without this, the save_when fails for IOS devices and the old save is deprecated, making it a relatively urgent issue IMO.

[termlen0]

Actually #32619 seems to be already raised for this, and is referenced above.

[pippozq]

same problem here, i temporaily modified the source like:
if running_config.sha1 != startup_config.sha1 or module.params['save_when'] == 'always':
result['changed'] = True
if not module.check_mode:
#run_commands(module, 'copy running-config startup-config')
run_commands(module, 'write')
else:
module.warn('Skipping command copy running-config startup-config '
'due to check_mode. Configuration not copied to '
'non-volatile storage')
which version will fix such problem, so i can update the ansible using pip