Add the template lookup escaping to the 2.4 porting guide #32760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
gundalow
requested changes
Nov 9, 2017
| Template lookup plugin | ||
| ---------------------- | ||
|
|
||
| Prior to Ansible 2.4, the strings passed to the template lookup plugin would have backslashes |
There was a problem hiding this comment.
template lookup plugin would have backslashes
Would have -> must have?
| @@ -131,6 +131,28 @@ Developers: | |||
| * Any callbacks inheriting from other callbacks might need to also be updated to contain the same documented options | |||
| as the parent or the options won't be available. This is noted in the developer guide. | |||
|
|
|||
| Template lookup plugin | |||
There was a problem hiding this comment.
Can we give more or a clue in the heading, perhaps?
Template lookup plugin: Escaping strings
| - debug: | ||
| msg: '{{ lookup("template", "tpl.j2") }}' | ||
|
|
||
| And the template in :file:`tpl.j2` is:: |
|
|
||
| {{ "name surname" | regex_replace("^[^\s]+\s+(.*)", "\1") }} | ||
|
|
||
| Change the template like this:: |
There was a problem hiding this comment.
in the 2.3 guide we used the form
OLD In Ansible 2.2 (and earlier)
NEW In Ansible 2.3:
ansibot
added
the
needs_revision
gundalow
approved these changes
Nov 9, 2017
gundalow
removed
the
needs_triage
|
The test |
ansibot
removed
ci_verified
dharmabumstead
approved these changes
Nov 11, 2017
dharmabumstead
approved these changes
Nov 11, 2017
abadger
added a commit
that referenced
this pull request
Nov 12, 2017
* Add the template lookup escaping to the 2.4 porting guide (cherry picked from commit faa74a8)
ansibot
added
docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change can break playbooks so make sure we include it in the porting guide.
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION