Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock ncclient import in test_connection.py #32786

Merged
merged 1 commit into from
Nov 10, 2017
Merged

mock ncclient import in test_connection.py #32786

merged 1 commit into from
Nov 10, 2017

Conversation

fredericlepied
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/units/plugins/connection/test_connection.py

ANSIBLE VERSION
ansible 2.5.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/fred/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/fred/work/DLRN/rawhide-data/ansible/.tox/py27/lib/python2.7/site-packages/ansible
  executable location = /home/fred/work/DLRN/rawhide-data/ansible/.tox/py27/bin/ansible
  python version = 2.7.13 (default, Sep  5 2017, 08:53:59) [GCC 7.1.1 20170622 (Red Hat 7.1.1-3)]
ADDITIONAL INFORMATION

If the ncclient python module isn't installed, the test test_connection will fail .

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Nov 10, 2017
@fredericlepied
Copy link
Contributor Author

This commit 9c0275a was breaking the Fedora package build without this change: http://38.145.33.116/ansible-devel/9c/02/9c0275a879d96eb9aee5e66987b1f07a013f23db_c8ca505b/build.log.gz

@mkrizek
Copy link
Contributor

mkrizek commented Nov 10, 2017

cc @Qalthos

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Nov 10, 2017
@Qalthos Qalthos merged commit 35f7937 into ansible:devel Nov 10, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. c:plugins/connection support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fredericlepied @mkrizek @Qalthos @ansibot