Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanups to nxos module_utils #32804

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Some cleanups to nxos module_utils #32804

merged 1 commit into from
Nov 13, 2017

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Nov 10, 2017

  • When splitting, use rsplit and 1 just in case the string has more pipe
    characters than anticipated
  • When converting to text, make decoding errors an error instead of
    silently corrupting data
  • When converting to text for message strings, use the default error
    handler as that is already surrogate_then_replace
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils/nxos.py

ANSIBLE VERSION
devel

@abadger
Some cleanups to nxos module_utils
ad02dfe 
* When splitting, use rsplit and 1 just in case the string has more pipe
  characters than anticipated
* When converting to text, make decoding errors an error instead of
  silently corrupting data
* When converting to text for message strings, use the default error
  handler as that is already surrogate_then_replace
@ansibot
Copy link
Contributor

ansibot commented Nov 10, 2017

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request module_utils/ needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 10, 2017
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Nov 10, 2017
@trishnaguha trishnaguha merged commit d970801 into ansible:devel Nov 13, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies module_utils/ networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abadger @ansibot @trishnaguha @dagwieers @s-hertel