Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_key: fix fingerprint generation in tests #32817

Merged
merged 1 commit into from
Nov 14, 2017
Merged

ec2_key: fix fingerprint generation in tests #32817

merged 1 commit into from
Nov 14, 2017

Conversation

prasadkatti
Copy link
Contributor

SUMMARY

Fix the way the fingerprint of the keypair is generated and enable checks verifying the fingerprint.

AWS generates the fingerprint of a keypair created using third-party tools differently, as mentioned in their docs -

If you created your key pair using a third-party tool and uploaded the public key to AWS, you can use the OpenSSL tools to generate a fingerprint from the private key file on your local machine:

$ openssl rsa -in path_to_private_key -pubout -outform DER | openssl md5 -c

The output should match the fingerprint that's displayed in the console.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_key

ANSIBLE VERSION
ansible 2.5.0

@ansibot
Copy link
Contributor

ansibot commented Nov 11, 2017

cc @zbal
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 11, 2017
@prasadkatti
Copy link
Contributor Author

ready_for_review

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Nov 11, 2017
@willthames willthames merged commit f891e92 into ansible:devel Nov 14, 2017
@willthames
Copy link
Contributor

Awesome work, thanks @prasadkatti

@prasadkatti prasadkatti deleted the ec2_key_fingerprint branch November 14, 2017 05:43
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Nov 17, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cloud support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prasadkatti @ansibot @willthames @s-hertel