Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow smartos vmadm to create docker vms #32819

Merged
merged 1 commit into from
Dec 8, 2017
Merged

allow smartos vmadm to create docker vms #32819

merged 1 commit into from
Dec 8, 2017

Conversation

fishman
Copy link
Contributor

@fishman fishman commented Nov 11, 2017 •
edited

SUMMARY

vmadm allows creating vms with docker images. the current vmadm.py will fail saying that docker in not an allowed option

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/cloud/smartos/vmadm.py

ANSIBLE VERSION

ansible 2.4.1.0
devel

@ansibot
Copy link
Contributor

ansibot commented Nov 11, 2017

@fishman Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 11, 2017

cc @jasperla
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 cloud module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 11, 2017
@ansibot
Copy link
Contributor

ansibot commented Nov 11, 2017

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/cloud/smartos/vmadm.py:0:0: E309 version_added for new option (docker) should be 2.5. Currently 0.0

click here for bot help

@ansibot ansibot added bugfix_pull_request ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Nov 11, 2017
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 11, 2017
gundalow
gundalow reviewed Nov 15, 2017
View reviewed changes
lib/ansible/modules/cloud/smartos/vmadm.py Outdated
docker:
required: false
description:
- Enable Docker mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it obvious what this means, could any extra information be given?
also missing full stop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole docker mode isn't exactly obvious to use, but I changed the description

@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Nov 15, 2017
@fishman
Copy link
Contributor Author

fishman commented Nov 28, 2017

@gundalow anything else that you need to get this merged?

jasperla
jasperla suggested changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@jasperla jasperla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a few nitpicks to address please :)

lib/ansible/modules/cloud/smartos/vmadm.py Outdated
docker:
required: false
description:
- Docker images need this flag enabled along with the brand set to lx.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use please use proper formatting for brand and lx to make it clear these refer to parameters? e.g. I(brand) set to C(lx).

lib/ansible/modules/cloud/smartos/vmadm.py Outdated
@@ -608,7 +613,8 @@ def main():
'bool': [
'archive_on_delete', 'autoboot', 'debug', 'delegate_dataset',
'firewall_enabled', 'force', 'indestructible_delegated',
'indestructible_zoneroot', 'maintain_resolvers', 'nowait'
'indestructible_zoneroot', 'maintain_resolvers', 'nowait',
'docker'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this list sorted.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 28, 2017
@fishman
Copy link
Contributor Author

fishman commented Nov 28, 2017

@jasperla done thanks, guess I should have seen the module documentation guide first

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Dec 7, 2017
@fishman
Copy link
Contributor Author

fishman commented Dec 7, 2017

@jasperla can we get this merged ?

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Dec 8, 2017
@gundalow gundalow merged commit aa74434 into ansible:devel Dec 8, 2017
@gundalow
Copy link
Contributor

gundalow commented Dec 8, 2017

Merging into devel. As this is actually a feature request (not a bug fix) it will NOT be backported.

Will be released in Ansible 2.5.0

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the solaris Solaris community label Jan 9, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasperla jasperla jasperla approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cloud community_review In order to be merged, this PR must follow the community review workflow. docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. solaris Solaris community support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fishman @ansibot @gundalow @jasperla @dagwieers