apt_repository does not recognize filename option

[sgutermann]

ISSUE TYPE

• Bug Report

COMPONENT NAME

apt_repository

ANSIBLE VERSION

ansible 2.3.1.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.9 (default, Jun 29 2016, 13:08:31) [GCC 4.9.2]

CONFIGURATION

No special configs, default install via pip

OS / ENVIRONMENT

Running ansible on debian jessie.

Deploying to debian stretch.

SUMMARY

FAILED! => {"changed": false, "failed": true, "msg": "Unsupported parameters for (apt_repository) module: filename. Supported parameters include: install_python_apt,mode,repo,state,update_cache,validate_certs"}

STEPS TO REPRODUCE

I simply followed the example in the documentation for apt_repository and added "filename" which should be available since ansible 2.1

- name: DOCKER | Add docker repo to apt
  apt_repository:
    repo: https://download.docker.com/linux/debian stretch stable
    state: present
    update_cache: yes
    filename: 'docker'

EXPECTED RESULTS

I expected to get the apt repo listed under the filename give as described in the documentation.

ACTUAL RESULTS

TASK [docker : DOCKER | Add docker repo to apt] *********************************************************************************************
fatal: [p4rt098.dip0.t-ipconnect.de]: FAILED! => {"changed": false, "failed": true, "msg": "Unsupported parameters for (apt_repository) module: filename. Supported parameters include: install_python_apt,mode,repo,state,update_cache,validate_certs"}

[pilou-]

codename parameter has been added in 2.3.0 and is neither listed in ACTUAL RESULTS.

@sgutermann could you check installed Ansible version ?

[ansibot]

cc @sashka
click here for bot help

[sgutermann]

ansible 2.3.1.0

[sgutermann]

Same on ansible 2.4.2.0

[pilou-]

Using devel or stable-2.4 branch and using the task mentioned in the description I got another error:

TASK [DOCKER | Add docker repo to apt] ****
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Invalid repository string: https://download.docker.com/linux/debian stretch stable"}

This error is legit, repo value must begin with deb or deb-src. Once the deb prefix added (repo: deb https://download.docker.com/linux/debian stretch stable), I encounter another legit error:

TASK [DOCKER | Add docker repo to apt] ***********************************************************************************************************************
fatal: [localhost]: FAILED! => {
    "changed": false,
    "rc": 0
}

MSG:

MODULE FAILURE


MODULE_STDOUT:

Traceback (most recent call last):
  File "/tmp/ansible_85nZ6F/ansible_module_apt_repository.py", line 547, in <module>
    main()
  File "/tmp/ansible_85nZ6F/ansible_module_apt_repository.py", line 535, in main
    cache.update()
  File "/usr/lib/python2.7/dist-packages/apt/cache.py", line 464, in update
    raise FetchFailedException(e)
apt.cache.FetchFailedException: W:GPG error: https://download.docker.com/linux/debian stretch InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 7EA0A9C3F273FCD8, E:The repository 'https://download.docker.com/linux/debian stretch InRelease' is not signed.

nonetheless the filename parameter was taken in account, the file was created:

# cat /etc/apt/sources.list.d/docker.list 
deb https://download.docker.com/linux/debian stretch stable

@sgutermann which error did you encounter ?

[sgutermann]

Sorry for not updating, but yes, I noticed that with the syntax, however even with the "deb" added in my above example I still get the same error.

Other Playbook, other repo:

fatal: [debian.lamido.de]: FAILED! => {
"changed": false,
"invocation": {
"module_args": {
"filename": "mssql",
"repo": "deb https://packages.microsoft.com/debian/8/prod jessie main",
"state": "present"
}
},
"msg": "Unsupported parameters for (apt_repository) module: filename Supported parameters include: install_python_apt,mode,repo,state,update_cache,validate_certs"
}

######################################

ansible 2.4.2.0
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/home/steffen/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.9 (default, Jun 29 2016, 13:08:31) [GCC 4.9.2]

[sgutermann]

Ok, this is STRANGE, but after completely cleaning out my python and ansible and installing it again it all works.

#########################################

ansible 2.4.2.0
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/home/steffen/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/steffen/.local/lib/python2.7/site-packages/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.13 (default, Nov 24 2017, 17:33:09) [GCC 6.3.0 20170516]