Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bigip_vcmp_guest module #33024

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Adds bigip_vcmp_guest module #33024

merged 1 commit into from
Nov 17, 2017

Conversation

caphrim007
Copy link
Contributor

SUMMARY

This module can be used to manage guests on a vCMP provisioned BIG-IP.
vCMP is a hardware-only feature, therefore this module cannot be used
on the VE editions of BIG-IP.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

bigip_vcmp_guest

ANSIBLE VERSION
ansible 2.5.0 (feature.add-bigip-vcmp-guest-module e5437033ed) last updated 2017/11/17 18:17:50 (GMT +000)
  config file = /here/test/integration/ansible.cfg
  configured module search path = [u'/here/library']
  ansible python module location = /here/local/ansible/lib/ansible
  executable location = /here/local/ansible/bin/ansible
  python version = 2.7.14 (default, Oct 10 2017, 02:49:49) [GCC 4.9.2]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Nov 17, 2017

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Nov 17, 2017
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Nov 17, 2017
@caphrim007
Copy link
Contributor Author

working on errors now

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 17, 2017
@caphrim007 caphrim007 force-pushed the feature.add-bigip-vcmp-guest-module branch from e543703 to 5b5216f Compare November 17, 2017 19:41
@ansibot
Copy link
Contributor

ansibot commented Nov 17, 2017

The test ansible-test sanity --test pep8 [?] failed with the following errors:

test/units/modules/network/f5/test_bigip_vcmp_guest.py:179:49: E231 missing whitespace after ','
test/units/modules/network/f5/test_bigip_vcmp_guest.py:179:54: E231 missing whitespace after ','
test/units/modules/network/f5/test_bigip_vcmp_guest.py:179:59: E231 missing whitespace after ','
test/units/modules/network/f5/test_bigip_vcmp_guest.py:179:64: E231 missing whitespace after ','

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Nov 17, 2017
@caphrim007
Adds bigip_vcmp_guest module
4abec7e 
This module can be used to manage guests on a vCMP provisioned BIG-IP.
vCMP is a hardware-only feature, therefore this module cannot be used
on the VE editions of BIG-IP.
@caphrim007 caphrim007 force-pushed the feature.add-bigip-vcmp-guest-module branch from 5b5216f to 4abec7e Compare November 17, 2017 19:51
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 17, 2017
@caphrim007 caphrim007 removed the core_review In order to be merged, this PR must follow the core review workflow. label Nov 17, 2017
@caphrim007 caphrim007 merged commit c94d573 into ansible:devel Nov 17, 2017
@caphrim007 caphrim007 mentioned this pull request Nov 17, 2017
Closed
@caphrim007 caphrim007 deleted the feature.add-bigip-vcmp-guest-module branch August 28, 2018 17:11
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 f5 module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caphrim007 @ansibot