Adding module enos_config and its UT files #33081

amuraleedhar · 2017-11-20T09:59:48Z

SUMMARY

Creating the config module for enos from Lenovo.

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

lib/ansible/modules/network/enos/enos_config.py
test/units/modules/network/enos/fixtures/enos_config_config.cfg
test/units/modules/network/enos/fixtures/enos_config_src.cfg
test/units/modules/network/enos/test_enos_config.py

ANSIBLE VERSION

ansible 2.5.0
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible-2.5.0-py2.7.egg/ansible
executable location = /usr/local/bin/ansible
python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

ADDITIONAL INFORMATION

This is an effort to create modules for enos based switches from Lenovo.

ansibot · 2017-11-20T10:07:29Z

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/modules/network/enos/enos_config.py:316:1: W391 blank line at end of file
test/units/modules/network/enos/test_enos_config.py:131:1: W391 blank line at end of file

The test ansible-test sanity --test pylint [?] failed with the following errors:

lib/ansible/modules/network/enos/enos_config.py:316:0: trailing-newlines Trailing newlines
test/units/modules/network/enos/test_enos_config.py:131:0: trailing-newlines Trailing newlines

click here for bot help

ansibot · 2017-11-20T10:07:29Z

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

amuraleedhar · 2017-11-20T10:55:04Z

Please review these for merging

gundalow · 2017-11-22T14:40:13Z

lib/ansible/modules/network/enos/enos_config.py

+    required: false
+    default: line
+    choices: ['line', 'block', 'config']
+  force:


Please remove force: as the message says match: none is the correct way of doing this

gundalow · 2017-11-22T14:40:30Z

lib/ansible/modules/network/enos/enos_config.py

+        match=dict(default='line', choices=['line', 'strict', 'exact', 'none']),
+        replace=dict(default='line', choices=['line', 'block', 'config']),
+
+        # this argument is deprecated in favor of setting match: none


Please remove force:

ganeshrn · 2017-11-22T14:41:33Z

lib/ansible/modules/network/enos/enos_config.py

+
+ANSIBLE_METADATA = {'metadata_version': '1.1',
+                    'status': ['preview'],
+                    'supported_by': 'network'}


This should be 'supported_by': 'community'

Changing it, Thanks

ansibot · 2017-11-23T09:13:28Z

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/modules/network/enos/enos_config.py:186:1: E302 expected 2 blank lines, found 1

click here for bot help

ansibot · 2017-11-23T09:21:19Z

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/modules/network/enos/enos_config.py:186:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [?] failed with the following error:

lib/ansible/modules/network/enos/enos_config.py:186:1: W293 blank line contains whitespace

click here for bot help

amuraleedhar · 2017-11-24T04:17:57Z

Please merge this now

gundalow · 2017-11-29T07:27:30Z

lib/ansible/modules/network/enos/enos_config.py

+    required: false
+    default: no
+    choices: ['yes', 'no']
+    version_added: "2.5"


Please remove this line.

As this is a new module the top-level version_added is the only one needed.

Changing Now

gundalow · 2017-11-29T07:27:39Z

lib/ansible/modules/network/enos/enos_config.py

+        not changed or committed, this argument is ignored.
+    required: false
+    default: 'configured by enos_config'
+    version_added: "2.5"


Please remove this line.

As this is a new module the top-level version_added is the only one needed.

Changing Now

gundalow · 2017-11-29T07:27:58Z

lib/ansible/modules/network/enos/enos_config.py

+    required: false
+    default: false
+    choices: [ "yes", "no" ]
+    version_added: "2.5"


Please remove this line.

As this is a new module the top-level version_added is the only one needed.

Removing now

gundalow · 2017-11-29T07:28:43Z

lib/ansible/modules/network/enos/enos_config.py

+        mutually exclusive with I(lines).
+    required: false
+    default: null
+    version_added: "2.5"


Please remove this line.

As this is a new module the top-level version_added is the only one needed.

Changing Now

gundalow · 2017-11-29T07:29:35Z

lib/ansible/modules/network/enos/enos_config.py

+EXAMPLES = """
+- name: configure top level configuration
+  enos_config:
+    lines: hostname {{ inventory_hostname }}


Should this be "lines: hostname {{ inventory_hostname }}"

gundalow · 2017-11-29T07:35:57Z

lib/ansible/modules/network/enos/enos_config.py

+    required: false
+    default: 'configured by enos_config'
+    version_added: "2.5"
+  admin:


Is this the same as EOS & IOS's privilege mode?

Would a password ever be needed

In Ansible 2.5 we are moving to using the standard Ansible 'becomesystem to enter enable mode, though that requiresconnection: network_cli`, which I don't believe you are currently using.

For ENOS, to get into privilege mode, by default , u dont need a password. Soon after login using admin/admin u are in exec mode. To go to Privilege Mode u just have to type in enable. I have already made in the sample / test roles in my Github with connection: network_cli. But I am facing an issue in my module_util file enos.py that in load_config method its coming as exec mode (> prompt, not # prompt ) I am at the moment testing it with this code
def load_config(module, config):
try:
conn = get_connection(module)
conn.get('enable')
conn.edit_config(config)
except ConnectionError as exc:
module.fail_json(msg=to_text(exc))
May be this will change once I put become=true and become_method = enable.
But as of now its not working for me

amuraleedhar · 2017-11-29T11:42:33Z

Please merge this now

amuraleedhar added 5 commits November 20, 2017 15:56

Adding module enos_config and its UT files

149ead4

Removing trailing line

92a6988

Removing trailing lines

290f611

Editing enos_module.py to fix build errors

b3e298b

Removing blank lines in end

aa66c96

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 20, 2017

amuraleedhar mentioned this pull request Nov 20, 2017

Network Working Group Meeting Agenda 2 ansible/community#247

Closed

bcoca removed the needs_triage Needs a first human triage before being processed. label Nov 20, 2017

gundalow requested changes Nov 22, 2017

View reviewed changes

ganeshrn reviewed Nov 22, 2017

View reviewed changes

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 22, 2017

Updating enos_config.py based on review comments

4375487

Adding one more blank line

6e58499

Anil Kumar Muraleedharan added 3 commits November 23, 2017 14:53

Removing training white space

5e517a3

Removing test_enos_config_force method from UT

1043c29

Updating documentation

1f253af

gundalow requested changes Nov 29, 2017

View reviewed changes

Comments by John, Remove version_added: "2.5"

ee7cc64

gundalow approved these changes Nov 29, 2017

View reviewed changes

gundalow merged commit bada3af into ansible:devel Nov 29, 2017

amuraleedhar deleted the lenovo-module-config branch August 9, 2018 11:22

ansible locked and limited conversation to collaborators Apr 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding module enos_config and its UT files #33081

Adding module enos_config and its UT files #33081

amuraleedhar commented Nov 20, 2017

ansibot commented Nov 20, 2017

ansibot commented Nov 20, 2017

amuraleedhar commented Nov 20, 2017

gundalow Nov 22, 2017

amuraleedhar Nov 23, 2017

gundalow Nov 22, 2017

amuraleedhar Nov 23, 2017

ganeshrn Nov 22, 2017

amuraleedhar Nov 23, 2017

ansibot commented Nov 23, 2017

ansibot commented Nov 23, 2017

amuraleedhar commented Nov 24, 2017

gundalow Nov 29, 2017

amuraleedhar Nov 29, 2017

gundalow Nov 29, 2017

amuraleedhar Nov 29, 2017

gundalow Nov 29, 2017

amuraleedhar Nov 29, 2017

gundalow Nov 29, 2017

amuraleedhar Nov 29, 2017

gundalow Nov 29, 2017

amuraleedhar Nov 29, 2017

gundalow Nov 29, 2017

amuraleedhar Nov 29, 2017

amuraleedhar commented Nov 29, 2017

Adding module enos_config and its UT files #33081

Adding module enos_config and its UT files #33081

Conversation

amuraleedhar commented Nov 20, 2017

ansibot commented Nov 20, 2017

ansibot commented Nov 20, 2017

amuraleedhar commented Nov 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ansibot commented Nov 23, 2017

ansibot commented Nov 23, 2017

amuraleedhar commented Nov 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amuraleedhar commented Nov 29, 2017