Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests for ec2_vpc_net #33111

Merged
merged 3 commits into from Dec 5, 2017
Merged

integration tests for ec2_vpc_net #33111

merged 3 commits into from Dec 5, 2017

Conversation

s-hertel
Copy link
Contributor

SUMMARY

I'm porting this module to boto3 and adding a feature to expand existing VPCs in #33105. These tests should be reviewed/merged first to ensure backwards compatibility.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

test/integration/targets/ec2_vpc_net

ANSIBLE VERSION
2.5.0

@s-hertel s-hertel mentioned this pull request Nov 21, 2017
Merged
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2017

cc @defionscode @willthames
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 cloud feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 21, 2017
willthames
willthames suggested changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@willthames willthames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great in general - can you just update the ec2-policy.json (or merge #33122 and then update compute-policy.json) to add the DHCP permissions?

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Nov 21, 2017
@s-hertel
Copy link
Contributor Author

@willthames Thanks for the review, I will update compute-policy.json!

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 29, 2017
@s-hertel
Copy link
Contributor Author

s-hertel commented Dec 4, 2017

@willthames Updated the test policy, do you mind updating your review? Not mergeable yet because I'm waiting for my PR for CI permissions/clean up to be approved.

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 4, 2017
willthames
willthames approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@willthames willthames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look really good and pass for me locally against us-east-2 after rerunning setup-iam.yml

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 5, 2017
@ryansb ryansb merged commit f5471b3 into ansible:devel Dec 5, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willthames willthames willthames approved these changes

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cloud feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@s-hertel @ansibot @willthames @ryansb