Handle facts for HP-UX 9000/785 architecture #33333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adds support for HP-UX '9000/785' architecture. Fixes: ansible#31976 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
affects_2.5
gundalow
removed
the
needs_triage
ansibot
removed
the
needs_revision
ansibot
added
the
stale_ci
alikins
reviewed
Dec 13, 2017
| @@ -55,7 +55,7 @@ def get_cpu_facts(self, collected_facts=None): | |||
| cpu_facts = {} | |||
| collected_facts = collected_facts or {} | |||
|
|
|||
| if collected_facts.get('ansible_architecture') == '9000/800': | |||
| if collected_facts.get('ansible_architecture') in ['9000/800', '9000/785']: | |||
There was a problem hiding this comment.
Do we know what the other possible values here are?
Can we generalize and assume any '^9000.*' ansible_architecture should use ioscan?
Could we invert the if/elif check for ia64 and else use ioscan?
roughly...
if collected.facts.get('ansible_architecture') == 'ia64':
# < ia64 stuff here >
else:
# < 9000 ioscan stuff here>or check for '9000' in arch?
if collected_facts.get('ansible_architecture') == 'ia64':
# < do ia64 stuff >
elif collected_facts.get('ansible_architecture', '').startswith('9000/'):
# < do 9000 ioscan stuff >
|
Think I'll merge for now and add an issue to generalize the check (#35055) |
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fix adds support for HP-UX '9000/785' architecture.
Fixes: #31976
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/facts/hardware/hpux.py
ANSIBLE VERSION