Additionally template args in role_include that affect role loading #33386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot_skip |
jimi-c
force-pushed
the
fixing_include_templating
branch
from
c911a01
to
b7bf73a
Compare
This fixes many issues with role_include by correctly templating and saving fields which affect role loading in the args for the role include.
jimi-c
force-pushed
the
fixing_include_templating
branch
from
b7bf73a
to
1fa3b96
Compare
This was referenced Nov 30, 2017
This was referenced Jan 8, 2018
|
@bcoca any chance to have this one backported in |
ansibot
added
bug
logan2211
added a commit
to logan2211/ansible-ramdisk-builder
that referenced
this pull request
May 23, 2018
Remove ansible 2.4 testing because it does not include a fix [1] which is required when include_role is used in a with_items loop. [1] ansible/ansible#33386
logan2211
added a commit
to logan2211/ansible-ramdisk-builder
that referenced
this pull request
May 23, 2018
Remove ansible 2.4 testing because it does not include a fix [1] which is required when include_role is used in a with_items loop. [1] ansible/ansible#33386
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes many issues with role_include by correctly templating and
saving fields which affect role loading in the args for the role include.