Rekey on member #33836
Merged
Rekey on member #33836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cast_list_to_dict was taking an arbitrary data format in and returning an arbitrary data format out. Rework this to be a more generic function which creates a dict of dicts based on a member of the dict. Remove cast_dict_to_list since rekey_on_member handles the use cases we know about and cast_dict_to_list suffers from the same problems as cast_list_to_dict. If this is still needed we could think about filters we could add to do this in a short jinja2 pipeline.
ansibot
added
affects_2.5
bcoca
reviewed
Dec 12, 2017
| raise errors.AnsibleFilterError("human_readable() can't interpret following string: %s" % size) | ||
|
|
||
|
|
||
| def human_to_bytes(size, default_unit=None, isbits=False): | ||
| ''' Return bytes count from a human readable string ''' | ||
| try: | ||
| return basic.human_to_bytes(size, default_unit, isbits) | ||
| except: | ||
| except Exception as e: |
There was a problem hiding this comment.
e is unsued, just except Exception: to avoid 'bare exceptions'
sivel
reviewed
Dec 12, 2017
| raise errors.AnsibleFilterError(to_native(e)) | ||
|
|
||
| # TODO: We may want to add parameters to allow overwrite or constructing lists instead of erroring | ||
| if new_obj.get(key_elem, None): |
There was a problem hiding this comment.
I think we should add an allow_overwrite or similar param.
Merged
abadger
force-pushed
the
rekey_on_member
branch
from
ad47558
to
a484732
Compare
|
Lol, good comments. I have come to understand that ansible core likes what ansible core likes. I do feel at times you have lost understanding of how users use products, but this does cover the main use case so let’s do it!!!! |
|
Merged to devel for the 2.5.0 release. |
mkrizek
removed
the
needs_triage
ansibot
added
feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Objections have been raised to the new filters, cast_list_to_dict() and cast_dict_to_list() which take an arbitrary data structure and transform it into another data structure. Renamed and reworked the filters and code so that the input and output are much less arbitrary.
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/filters/mathstuff.py
lib/ansible/plugins/filters/cast_type.py
ANSIBLE VERSION
ADDITIONAL INFORMATION
I was only given one use case. Here's how that one case would compare to the new code as well as how to use the new code in other ways: https://gist.github.com/abadger/af5e5b03b8d8a121f983cc98743062cc