windows: updated docs to include info regarding https validation #34128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
dharmabumstead
suggested changes
Dec 21, 2017
docs/docsite/rst/windows_winrm.rst
Outdated
| One of the more common ways of setting up a HTTPS listener in a domain | ||
| environment is to use Active Directory Certificate Service (AD CS). AD CS is | ||
| used by Active Directory to sign certificate requests that are sent to it and | ||
| then issue a certificate from the csr. The issuer certificate of the AD CS |
There was a problem hiding this comment.
Explain what a “CSR” is. In general, define abbreviations on first use and then you can just use the abbreviation (capitalized, please) for subsequent mentions.
docs/docsite/rst/windows_winrm.rst
Outdated
|
|
||
| This file can either contain the single issuer certificate or multiple | ||
| certificates. To then use this file as part of the valiation process, set | ||
| ``ansible_winrm_ca_trust_path`` to the path of the. If this value is not set |
There was a problem hiding this comment.
Please either remove the word “which” or add parenthesis around that part of the sentence so it makes it easier to understand.
docs/docsite/rst/windows_winrm.rst
Outdated
| the `certifi <https://github.com/certifi/python-certifi>`_ package is used. | ||
|
|
||
| .. Note:: Each HTTP call is done by the Python requests library which does not | ||
| use the systems built in certificate store as a trust authority. |
There was a problem hiding this comment.
“system’s built-in”
ansibot
added
the
needs_revision
|
Thanks @dharmabumstead, I've made a few edits around some of the sentences so it is ready for review again. |
jborean93
removed
the
needs_triage
ansibot
added
stale_ci
jborean93
force-pushed
the
win-https-docs
branch
from
b5158de
to
6b13777
Compare
ansibot
removed
stale_ci
ansibot
added
docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updated Windows docs to contain more information regarding the latest pywinrm release.
ISSUE TYPE
COMPONENT NAME
windows docs
ANSIBLE VERSION