Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nso_show module for Cisco NSO #34142

Merged
merged 2 commits into from
Dec 22, 2017
Merged

Add nso_show module for Cisco NSO #34142

merged 2 commits into from
Dec 22, 2017

Conversation

cnasten
Copy link
Contributor

@cnasten cnasten commented Dec 21, 2017

SUMMARY

Add nso_show module for Cisco NSO that allows retrieving configuration and operational data from Cisco NSO.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

nso_show

ANSIBLE VERSION
ansible 2.5.0 (nso_show c2838f290b) last updated 2017/12/21 14:12:37 (GMT +200)
  config file = None
  configured module search path = [u'/home/cnasten/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/cnasten/dev/ansible/lib/ansible
  executable location = /home/cnasten/dev/ansible/bin/ansible
  python version = 2.7.14+ (default, Dec  5 2017, 15:17:02) [GCC 7.2.0]
ADDITIONAL INFORMATION

@cnasten
update version parsing and move requirements to nso_* modules
98ac55c 
prepare for introduction of nso_show module that has other version
requirements than the existing nso_* modules.
@cnasten
Add nso_show module for retreiving config from Cisco NSO
572eb35 
New module that supports getting configuration and operational data
from Cisco NSO.
@ansibot
Copy link
Contributor

ansibot commented Dec 21, 2017

cc @Qalthos @cmoberg @ganeshrn @gundalow @kedarX @pekdon @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Dec 21, 2017
@cmoberg
Copy link

cmoberg commented Dec 21, 2017

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Dec 21, 2017
gundalow
gundalow reviewed Dec 22, 2017
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this after merge

lib/ansible/modules/network/nso/nso_show.py
required: true
operational:
description: >
Controls wheter or not operational data is included in the result.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whether

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #34186

@gundalow gundalow merged commit d6fd970 into ansible:devel Dec 22, 2017
@gundalow
Copy link
Contributor

Merged into devel will be released in 2.5.0

@dagwieers dagwieers added nso Cisco NSO community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. nso Cisco NSO community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cnasten @ansibot @cmoberg @gundalow @dagwieers