Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Avi Modules with new features and documentation update. #34206

Merged
merged 2 commits into from
Dec 24, 2017

Conversation

grastogi23
Copy link
Contributor

SUMMARY
  1. Support to perform patch operation using the modules. The data update method is
    selected using avi_api_update_method=patch and patch operation is determined by
    avi_api_patch_op. The patch data is the normal params that are provided in the modules

  2. Support for avi_credentials as single authentication dictionary for all API calls.
    This is preferred way as opposed to previously all credentials details would pollute
    the individual Ansible tasks. It also allows the module development to be enhanced
    without breaking compatibility for new authentication schemes like SAML etc.

  3. Support for sharing api_context between the module invocations. This is a
    workaround to not do multiple logins to Avi Controller and be able to
    re-use single login across multiple REST API calls.

  4. Documentation update for new parameters and existing ones with Units data.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

network/avi

ANSIBLE VERSION
ansible 2.5.0
  config file = /home/grastogi/.ansible.cfg
  configured module search path = [u'/home/grastogi/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/grastogi/trace/ansible2.5/local/lib/python2.7/site-packages/ansible
  executable location = /home/grastogi/trace/ansible2.5/bin/ansible
  python version = 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2]
ADDITIONAL INFORMATION

1. Support to perform patch operation using the modules. The data update method is
selected using avi_api_update_method=patch and patch operation is determined by
avi_api_patch_op. The patch data is the normal params that are provided in the modules

2. Support for avi_credentials as single authentication dictionary for all API calls.
This is preferred way as opposed to previously all credentials details would pollute
the individual Ansible tasks. It also allows the module development to be enhanced
without breaking compatibility for new authentication schemes like SAML etc.

3. Support for sharing api_context between the module invocations. This is a
workaround to not do multiple logins to Avi Controller and be able to
re-use single login across multiple REST API calls.

4. Documentation update for new parameters and existing ones with Units data.
@ansibot
Copy link
Contributor

ansibot commented Dec 22, 2017

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 avi core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 22, 2017
@khaltore
Copy link

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Dec 22, 2017
@ansibot
Copy link
Contributor

ansibot commented Dec 22, 2017

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/module_utils/network/avi/avi.py:90:0: missing-final-newline Final newline missing

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/module_utils/network/avi/avi.py:90:53: W292 no newline at end of file
lib/ansible/utils/module_docs_fragments/avi.py:54:79: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Dec 22, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 22, 2017
@gundalow gundalow merged commit 9e2ff3e into ansible:devel Dec 24, 2017
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 avi core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants