Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: Add 'generic' connection type #34251

Merged
merged 1 commit into from
Jan 2, 2018
Merged

nmcli: Add 'generic' connection type #34251

merged 1 commit into from
Jan 2, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

This fix adds 'generic' connection type in nmcli module.

Fixes: #33648

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/net_tools/nmcli.py
test/units/modules/net_tools/test_nmcli.py

ANSIBLE VERSION
2.5devel

@Akasurde Akasurde mentioned this pull request Dec 27, 2017
Closed
@Akasurde
Copy link
Member Author

cc @Colins-Git

@ansibot
Copy link
Contributor

ansibot commented Dec 27, 2017

cc @alcamie101
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Dec 27, 2017
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Dec 27, 2017
@ansibot
Copy link
Contributor

ansibot commented Dec 27, 2017

The test ansible-test sanity --test shebang [?] failed with the following error:

Command "test/sanity/code-smell/shebang.sh" returned exit status 1.
>>> Standard Output
./test/units/modules/net_tools/test_nmcli.py:#!/usr/bin/python
One or more file(s) listed above have an unexpected shebang.
See test/sanity/code-smell/shebang.sh for the list of acceptable values.

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 27, 2017
@Akasurde
nmcli: Add 'generic' connection type
de4a5b7 
This fix adds 'generic' connection type in nmcli module.

Fixes: ansible#33648

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 27, 2017
mkrizek
mkrizek approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@mkrizek mkrizek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkrizek mkrizek merged commit 5496326 into ansible:devel Jan 2, 2018
@Akasurde
Copy link
Member Author

Akasurde commented Jan 2, 2018

@mkrizek Thanks for review.

@Akasurde Akasurde deleted the i33648 branch January 2, 2018 11:39
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nmcli: Allow "generic" type for connections
3 participants
@Akasurde @ansibot @mkrizek