Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: Allow setting ipv4.dhcp-client-id parameter #34268

Merged
merged 1 commit into from
Jan 29, 2018
Merged

nmcli: Allow setting ipv4.dhcp-client-id parameter #34268

merged 1 commit into from
Jan 29, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Orion Poplawski orion@cora.nwra.com
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/net_tools/nmcli.py
test/units/modules/net_tools/test_nmcli.py

ANSIBLE VERSION
2.5devel

This was referenced Dec 28, 2017
Closed
Closed
@ansibot
Copy link
Contributor

ansibot commented Dec 28, 2017

cc @alcamie101
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 28, 2017
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 28, 2017
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Dec 31, 2017
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 8, 2018
@Akasurde Akasurde requested a review from mkrizek January 9, 2018 04:19
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 9, 2018
@Akasurde Akasurde force-pushed the i29259 branch 2 times, most recently from 010b43d to 4d7d873 Compare January 17, 2018 14:05
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 17, 2018
@Akasurde
Copy link
Member Author

@Colins-Git Could you please review this ?

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 25, 2018
@Akasurde
Copy link
Member Author

@maxamillion Could you please review this ?

@opoplawski @Akasurde
nmcli: Allow setting ipv4.dhcp-client-id parameter
fe6575c 
Signed-off-by: Orion Poplawski <orion@cora.nwra.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 28, 2018
@maxamillion maxamillion merged commit becb31f into ansible:devel Jan 29, 2018
Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@Akasurde @Lujeni
nmcli: Allow setting ipv4.dhcp-client-id parameter (ansible#34268)
39d0bca 
Signed-off-by: Orion Poplawski <orion@cora.nwra.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde deleted the i29259 branch February 2, 2018 07:50
@Akasurde
Copy link
Member Author

Akasurde commented Feb 2, 2018

@maxamillion Thanks for review and merge.

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

@mkrizek mkrizek Awaiting requested review from mkrizek

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Akasurde @ansibot @maxamillion @opoplawski