Add new module mlnxos_facts for retrieving facts of MLNX-OS Mellanox network devices #34287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
network devices Signed-off-by: Samer Deeb <samerd@mellanox.com>
ansibot
added
affects_2.5
ganeshrn
approved these changes
Dec 29, 2017
ganeshrn
removed
the
needs_triage
gundalow
requested changes
Jan 3, 2018
| """ | ||
|
|
||
| EXAMPLES = """ | ||
| # Note: examples below use the following provider dict to handle |
| # Note: examples below use the following provider dict to handle | ||
| # transport and authentication to the node. | ||
| --- | ||
| # Collect all facts from the device |
There was a problem hiding this comment.
Please change the comment to a name:, e.g.
- name: Collect all facts from the device
mlnxos_facts:
gather_subset: all
Best practice is to specify a name: in Ansible. We find people often copy examples when writing playbooks.
ansibot
added
needs_revision
Signed-off-by: Samer Deeb <samerd@mellanox.com>
|
@samerd Hi, do you think this is ready for final review and merge? |
|
@gundalow : yes, please review and merge if it is OK. |
gundalow
approved these changes
Jan 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Samer Deeb samerd@mellanox.com
SUMMARY
Add module mlnxos_facts for retrieving facts of MLNX-OS Mellanox switches
the module manages the facts: version, interfaces and modules.
ISSUE TYPE
COMPONENT NAME
modules/network/mlnxos/mlnxos_facts
ANSIBLE VERSION
ADDITIONAL INFORMATION