Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config option to replace argument nxos_config #34342

Merged
merged 1 commit into from
Jan 15, 2018
Merged

add config option to replace argument nxos_config #34342

merged 1 commit into from
Jan 15, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Jan 2, 2018 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

fixes #30979
add config option to replace argument nxos_config
config replace is supported for Nexus 9K series of switches.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/network/nxos/nxos_config

ANSIBLE VERSION
devel

@trishnaguha trishnaguha mentioned this pull request Jan 2, 2018
Closed
@trishnaguha trishnaguha added networking Network category nxos Cisco NXOS community labels Jan 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 2, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jan 2, 2018
@trishnaguha trishnaguha added this to the 2.5.0 milestone Jan 2, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 4, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 4, 2018
gundalow
gundalow reviewed Jan 5, 2018
View reviewed changes
lib/ansible/modules/network/nxos/nxos_config.py Outdated
@@ -249,6 +261,11 @@
parents: ip access-list test
before: no ip access-list test
replace: block

- nxos_config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a -name: explaining what this is doing (and on the other examples above)

remember to remove the - from infront of - nxos_config

@trishnaguha
add config option to replace argument
26f7f55 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha merged commit a65f702 into ansible:devel Jan 15, 2018
@trishnaguha trishnaguha deleted the nxos_replace_config branch January 15, 2018 15:47
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

@privateip privateip privateip approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@kedarkekan kedarkekan Awaiting requested review from kedarkekan

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees

@trishnaguha trishnaguha

Labels
affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

nxos_config should support config replace
5 participants
@trishnaguha @ansibot @privateip @gundalow @dagwieers