Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aci_interface_policy_leaf_profile module #34364

Merged
merged 18 commits into from
Jan 12, 2018
Merged

aci_interface_policy_leaf_profile module #34364

merged 18 commits into from
Jan 12, 2018

Conversation

brunocalogero
Copy link
Contributor

SUMMARY

Created new module to add ACI Fabric interface policy leaf profile (infra:AccPortP).
This is a WIP, integration testing still needed.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_interface_policy_leaf_profile

ANSIBLE VERSION
2.5

bcaloger added 16 commits December 15, 2017 15:35
@ansibot
Copy link
Contributor

ansibot commented Jan 2, 2018

cc @dagwieers @jmcgill298 @schunduri
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 2, 2018
dagwieers
dagwieers approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 2, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 10, 2018
@brunocalogero brunocalogero changed the title WIP: added aci_interface_policy_leaf_profile module aci_interface_policy_leaf_profile module Jan 12, 2018
@brunocalogero
Copy link
Contributor Author

integration tests + examples in process of being added

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

The test ansible-test sanity --test pylint [?] failed with the following errors:

lib/ansible/modules/network/aci/aci_interface_policy_leaf_profile.py:103:19: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/network/aci/aci_interface_policy_leaf_profile.py:104:26: ansible-format-automatic-specification Format string contains automatic field numbering specification

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Jan 12, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

The test ansible-test sanity --test pylint [?] failed with the following errors:

lib/ansible/modules/network/aci/aci_interface_policy_leaf_profile.py:110:19: ansible-format-automatic-specification Format string contains automatic field numbering specification
lib/ansible/modules/network/aci/aci_interface_policy_leaf_profile.py:111:26: ansible-format-automatic-specification Format string contains automatic field numbering specification

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 12, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

@jmcgill298 @schunduri

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 12, 2018
@dagwieers dagwieers merged commit 007c190 into ansible:devel Jan 12, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunocalogero @ansibot @dagwieers