Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EOS code to use cliconf #34426

Merged
merged 4 commits into from
Jan 11, 2018
Merged

Refactor EOS code to use cliconf #34426

merged 4 commits into from
Jan 11, 2018

Conversation

rcarrillocruz
Copy link
Contributor

No description provided.

@ansibot
Copy link
Contributor

ansibot commented Jan 3, 2018 •
edited by rcarrillocruz

SUMMARY

Refactor EOS code to use cliconf

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

eos

ANSIBLE VERSION
ansible 2.5.0 (refactor_eos_cliconf bfb763b6d9) last updated 2018/01/10 10:43:35 (GMT +200)

@ansibot
Copy link
Contributor

ansibot commented Jan 3, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @privateip @trishnaguha
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.5 This issue/PR affects Ansible v2.5 needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 3, 2018
@rcarrillocruz rcarrillocruz changed the title WIP Refactor EOS code to use cliconf Refactor EOS code to use cliconf Jan 10, 2018
@rcarrillocruz rcarrillocruz mentioned this pull request Jan 10, 2018
Closed
@ansibot ansibot removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Jan 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2018

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/module_utils/network/eos/eos.py:176:16: undefined-variable Undefined variable 'module'

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 10, 2018
@rcarrillocruz rcarrillocruz reopened this Jan 10, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Jan 10, 2018
@rcarrillocruz
Remove return from send_config and various exec_commands
dab37af 
Also, removed a few try/except, which are anyways handled in
Connection.
@rcarrillocruz rcarrillocruz removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 11, 2018
@rcarrillocruz
Copy link
Contributor Author

merging, CI unstability unrelated to code change

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 11, 2018
@rcarrillocruz rcarrillocruz merged commit 32e7c9b into ansible:devel Jan 11, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rcarrillocruz @ansibot @trishnaguha @gundalow