Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors the bigip_sys_global module #34438

Merged

Conversation

caphrim007
Copy link
Contributor

SUMMARY

Changes include the current f5 coding standards and unit tests
for the module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bigip_sys_global

ANSIBLE VERSION
ansible 2.5.0
  config file = /here/test/integration/ansible.cfg
  configured module search path = [u'/here/library']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Dec 12 2017, 16:55:09) [GCC 4.9.2]
ADDITIONAL INFORMATION

Changes include the current f5 coding standards and unit tests
for the module
@ansibot
Copy link
Contributor

ansibot commented Jan 4, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 4, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Jan 4, 2018
@caphrim007 caphrim007 merged commit bdafb42 into ansible:devel Jan 4, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@caphrim007 caphrim007 deleted the bugfix.refactor-bigip-sys-global branch August 28, 2018 17:11
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants