Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins_script - Do not prevent username logging #34459

Merged
merged 1 commit into from Jan 4, 2018
Merged

jenkins_script - Do not prevent username logging #34459

merged 1 commit into from Jan 4, 2018

Conversation

olivergondza
Copy link
Contributor

SUMMARY

Jenkins username used for HTTP request is obscured by ******** in jenkins_script output. This is problematic as valid username has a nonzero chance in appearing in script output that is therefore mangled.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

jenkins_script

ANSIBLE VERSION
ansible 2.4.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/ogondza/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.14 (default, Sep 20 2017, 01:25:59) [GCC 7.2.0]
ADDITIONAL INFORMATION

Username is not a secret as such so there is no need to obscure it. Sibling modules, jenkins_job and jenkins_plugin, do not use it.

@olivergondza olivergondza mentioned this pull request Jan 4, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 4, 2018

cc @hogarthj
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 4, 2018
@resmo
Copy link
Contributor

resmo commented Jan 4, 2018

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 4, 2018
@hogarthj
Copy link
Contributor

hogarthj commented Jan 4, 2018

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 4, 2018
@ansibot ansibot merged commit 30cae1c into ansible:devel Jan 4, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olivergondza @ansibot @resmo @hogarthj