Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iosxr integration tests #34663

Merged
merged 4 commits into from Jan 10, 2018
Merged

Fix iosxr integration tests #34663

merged 4 commits into from Jan 10, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Jan 9, 2018

SUMMARY

Fixes the netconf tests and cleans up some other things I missed the first time

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iosxr

ANSIBLE VERSION
2.5

@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2018

cc @ganeshrn @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jan 9, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 9, 2018
@mattclay
Copy link
Member

mattclay commented Jan 9, 2018

CI failure in sanity tests is valid. The integration test errors are unrelated and can be ignored.

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jan 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2018

The test ansible-test sanity --test import --python 2.6 [?] failed with the following error:

lib/ansible/module_utils/network/common/netconf.py:34:0: ImportError: cannot import name XMLSyntaxError

The test ansible-test sanity --test import --python 2.7 [?] failed with the following error:

lib/ansible/module_utils/network/common/netconf.py:34:0: ImportError: cannot import name XMLSyntaxError

The test ansible-test sanity --test import --python 3.5 [?] failed with the following error:

lib/ansible/module_utils/network/common/netconf.py:34:0: ImportError: cannot import name 'XMLSyntaxError'

The test ansible-test sanity --test import --python 3.6 [?] failed with the following error:

lib/ansible/module_utils/network/common/netconf.py:34:0: ImportError: cannot import name 'XMLSyntaxError'

The test ansible-test sanity --test import --python 3.7 [?] failed with the following error:

lib/ansible/module_utils/network/common/netconf.py:34:0: ImportError: cannot import name 'XMLSyntaxError' from 'xml.etree.ElementTree' (/usr/local/opt/pyenv/versions/3.7-dev/lib/python3.7/xml/etree/ElementTree.py)

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 9, 2018
kedarkekan
kedarkekan reviewed Jan 10, 2018
View reviewed changes
lib/ansible/module_utils/network/common/netconf.py
raise ConnectionError(to_text(rpc_error, errors='surrogate_then_replace'))
return warnings
except XMLSyntaxError:
raise ConnectionError(rpc_error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess as xml.tree doesn't have XMLSyntaxError , a catch all except: would be good here when lxml is not installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're importing three different exceptions to that name, depending on context, but I think we should have everything covered now

@Qalthos Qalthos merged commit accf79f into ansible:devel Jan 10, 2018
@Qalthos Qalthos deleted the iosxr-net branch January 10, 2018 16:41
@ansibot ansibot added the bug This issue/PR relates to a bug. label Mar 6, 2018
@dagwieers dagwieers added iosxr Cisco IOSXR community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@kedarkekan kedarkekan kedarkekan approved these changes

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cisco Cisco technologies iosxr Cisco IOSXR community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Qalthos @ansibot @mattclay @gundalow @kedarkekan @dagwieers