fix of some problems with user modification with skeleton informations under FreeBSD #34694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than ansible's create_home(), which does not handle skeleton files correctly for FreeBSD
ansibot
added
affects_2.5
jborean93
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
bug
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
…s under FreeBSD (ansible#34694) * respect skeleton argument in usermod mode for FreeBSD * use FreeBSD's own (more sophisticated) home creation function rather than ansible's create_home(), which does not handle skeleton files correctly for FreeBSD
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
FreeBSD handles skeleton files somehow different than other OSs. Skeleton files in /etc/skel/ are prefixed with "dot". When adding or modifying a user with
pwand argument-mfiles from the skeleton directory will be copied to the home directory of the user and the "dot" prefix will be removed. Ansible's own create_homedir() function only copies the skeleton files without renaming them properly under FreeBSD.With this patch/bug fix the home directory of an existing user without existing home directory will be created properly under FreeBSD by using FreeBSD's own functions.
ISSUE TYPE
COMPONENT NAME
user
ANSIBLE VERSION