Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant connection vars from ios tests #34703

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Remove redundant connection vars from ios tests #34703

merged 1 commit into from
Jan 10, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Jan 10, 2018

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios

ANSIBLE VERSION
2.5

@Qalthos
Remove vars from include for ios netowrk_cli tests
3d68b87 
These should be specified in inventory for 2.5+
@Qalthos Qalthos changed the title Reverse ios test become logic Remove redundant connection vars from ios tests Jan 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2018

cc @ganeshrn @jmcgill298 @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Jan 10, 2018
@Qalthos Qalthos merged commit db44602 into ansible:devel Jan 10, 2018
@Qalthos Qalthos deleted the ios-become branch January 10, 2018 17:59
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jan 19, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@dagwieers dagwieers added ios Cisco IOS community cisco Cisco technologies networking Network category labels Feb 27, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow Awaiting requested review from gundalow

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. cisco Cisco technologies ios Cisco IOS community networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Qalthos @ansibot @dagwieers @s-hertel