Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor iosxr_system for cliconf and netconf #34749

Merged
merged 2 commits into from
Jan 17, 2018
Merged

refactor iosxr_system for cliconf and netconf #34749

merged 2 commits into from
Jan 17, 2018

Conversation

kedarkekan
Copy link
Contributor

SUMMARY

Fixes #33324

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iosxr_system

ANSIBLE VERSION
2.5.0

@kedarkekan kedarkekan added the affects_2.5 This issue/PR affects Ansible v2.5 label Jan 11, 2018
@kedarkekan kedarkekan added this to the 2.5.0 milestone Jan 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 11, 2018

cc @Qalthos @ganeshrn @gundalow @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 11, 2018
@mattclay
Copy link
Member

CI failure in unit tests:

https://app.shippable.com/github/ansible/ansible/runs/50172/2/tests

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jan 11, 2018
@ansible ansible deleted a comment from ansibot Jan 12, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 12, 2018
@kedarkekan kedarkekan changed the title refactor iosxr_system for cliconf and netconf [wip] refactor iosxr_system for cliconf and netconf Jan 12, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 12, 2018
@kedarkekan kedarkekan changed the title [wip] refactor iosxr_system for cliconf and netconf refactor iosxr_system for cliconf and netconf Jan 15, 2018
@gundalow gundalow added this to In Review in Networking Jan 16, 2018
@calfonso calfonso merged commit 93acd7c into ansible:devel Jan 17, 2018
@kedarkekan kedarkekan deleted the iosxr_system_refactor branch January 17, 2018 14:31
@trishnaguha trishnaguha moved this from In Review to Done in Networking Jan 18, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added iosxr Cisco IOSXR community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Networking
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

[NETCONF] Refactor IOSXR modules to support netconf plugin
6 participants
@kedarkekan @ansibot @mattclay @gundalow @calfonso @dagwieers