Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added 'local' option to group #34805

Merged
merged 3 commits into from
Feb 9, 2018
Merged

added 'local' option to group #34805

merged 3 commits into from
Feb 9, 2018

Conversation

miticojo
Copy link
Contributor

SUMMARY

a new option that lets user force the usage of lgroupXXX alternatives for the commands
fixes #34804

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

group

@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

cc @sfromm
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/system/group.py:0:0: E308 version_added for new option (local) is not a valid version number: '2.4.x'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 12, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jan 12, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 14, 2018
@ansibot ansibot added new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 22, 2018
@bcoca bcoca merged commit 54e0327 into ansible:devel Feb 9, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Force group creation to be local
4 participants
@miticojo @ansibot @bcoca @mkrizek