Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and changes for F5 #34817

Conversation

caphrim007
Copy link
Contributor

SUMMARY

Primarily, this patch contains refactors to remove tracebacks that
are generated when libraries are missing. There is also,

  • Removed re-def of cleanup_tokens.
  • Changed parameter args to be keywords.
  • Changed imports to include new module_util locations.
  • Imports also include developing (sideband) module_util locations.
  • Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
  • Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
  • Changed module and module param references to take into account the new self.module arg. Minor bug fixes made during this refactor.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

various f5 modules

ANSIBLE VERSION
ansible 2.5.0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Dec 12 2017, 16:55:09) [GCC 4.9.2]
ADDITIONAL INFORMATION

Primarily, this patch contains refactors to remove tracebacks that
are generated when libraries are missing. There is also,

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg. Minor bug fixes made during this refactor.
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 12, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Jan 12, 2018
@caphrim007 caphrim007 merged commit eace686 into ansible:devel Jan 12, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@caphrim007 caphrim007 deleted the bugfix.correct-traceback-errors-that-are-raised-02 branch August 28, 2018 17:12
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants