Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend validate-modules to check the next to last line #34819

Merged
merged 5 commits into from
Jan 15, 2018
Merged

Extend validate-modules to check the next to last line #34819

merged 5 commits into from
Jan 15, 2018

Conversation

jctanner
Copy link
Contributor

SUMMARY

Verifies the next to last line is ...

if __name__ == "__main__":
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

validate-modules

ANSIBLE VERSION
2.5

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 docs_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following error:

lib/ansible/modules/database/mysql/mysql_replication.py:364:0: E109 Next to last line should be: if __name__ == "__main__":

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 12, 2018
@gundalow gundalow added ci_verified Changes made in this PR are causing tests to fail. and removed needs_triage Needs a first human triage before being processed. labels Jan 13, 2018
@gundalow
Copy link
Contributor

Looks good. You want to fix lib/ansible/modules/database/mysql/mysql_replication.py in this PR then merge?

@ansibot
Copy link
Contributor

ansibot commented Jan 13, 2018

cc @banyek
click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 13, 2018
@gundalow gundalow merged commit b10d5f3 into ansible:devel Jan 15, 2018
@ansibot ansibot added docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 4, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@gundalow gundalow gundalow approved these changes

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jctanner @ansibot @gundalow @mattclay