Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module renamed to ucs_mac_pool #34826

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Module renamed to ucs_mac_pool #34826

merged 1 commit into from
Jan 15, 2018

Conversation

dsoper2
Copy link
Contributor

@dsoper2 dsoper2 commented Jan 12, 2018

SUMMARY

Module renamed to ucs_mac_pool to match naming convention for other ucs modules.
Documentation updated to match UCS Manager online help.
Coding style updated to match other ucs modules.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ucs_mac_pool

ANSIBLE VERSION
ansible 2.5.0 (ucs_mac_pool 8e37d93a6f) last updated 2018/01/12 17:00:46 (GMT -500)
  config file = None
  configured module search path = [u'/Users/dsoper/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/dsoper/Documents/ansible/lib/ansible
  executable location = /Users/dsoper/Documents/ansible/bin/ansible
  python version = 2.7.12 (default, Oct 11 2016, 05:20:59) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.38)]
ADDITIONAL INFORMATION

Module renamed to ucs_mac_pool to match naming convention for other u…
8e37d93 
…cs modules.

Documentation updated to match UCS Manager online help.
Coding style updated to match other ucs modules.
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

cc @CiscoUcs @dagwieers @johnamcdonough @vallard @vvb
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. ucs Cisco UCS community labels Jan 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2018

@CiscoUcs @johnamcdonough @vallard @vvb

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@dagwieers dagwieers merged commit b7906f9 into ansible:devel Jan 15, 2018
@dsoper2 dsoper2 deleted the ucs_mac_pool branch January 16, 2018 18:50
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Jan 19, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. ucs Cisco UCS community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsoper2 @ansibot @dagwieers @s-hertel