Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors and deprecation removals #34830

Conversation

caphrim007
Copy link
Contributor

SUMMARY

This patch is primarily a refactor to make the validate-modules arg-spec
no longer generate a traceback. It additionally includes removal of deprecated
code in the virtual server module.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

various f5 modules

ANSIBLE VERSION
ansible 2.5.0
  config file = /here/test/integration/ansible.cfg
  configured module search path = [u'/here/library']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.14 (default, Dec 12 2017, 16:55:09) [GCC 4.9.2]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 13, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 13, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Jan 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 13, 2018

The test ansible-test sanity --test validate-modules [?] failed with the following errors:

lib/ansible/modules/network/f5/bigip_vlan.py:0:0: E309 version_added for new option (cmp_hash) should be 2.5. Currently 0.0
lib/ansible/modules/network/f5/bigip_vlan.py:0:0: E309 version_added for new option (dag_round_robin) should be 2.5. Currently 0.0
lib/ansible/modules/network/f5/bigip_vlan.py:0:0: E309 version_added for new option (dag_tunnel) should be 2.5. Currently 0.0
lib/ansible/modules/network/f5/bigiq_regkey_pool.py:0:0: E321 Exception attempting to import module for argument_spec introspection

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 13, 2018
This patch is primarily a refactor to make the validate-modules arg-spec
no longer generate a traceback. It additionally includes removal of deprecated
code in the virtual server module.
@caphrim007 caphrim007 force-pushed the bugfix.correct-traceback-errors-that-are-raised-05 branch from ebd6f86 to 1905e89 Compare January 13, 2018 06:31
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 13, 2018
@caphrim007 caphrim007 merged commit c548ab0 into ansible:devel Jan 13, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@caphrim007 caphrim007 deleted the bugfix.correct-traceback-errors-that-are-raised-05 branch August 28, 2018 17:12
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. f5 module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants