Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACI_BD: Add option to set mac-address #34843

Merged
merged 5 commits into from Jan 15, 2018
Merged

ACI_BD: Add option to set mac-address #34843

merged 5 commits into from Jan 15, 2018

Conversation

jmcgill298
Copy link
Contributor

@jmcgill298 jmcgill298 commented Jan 14, 2018 •
edited by dagwieers

SUMMARY

Add option to set MAC Address in ACI BD module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aci_bd

ANSIBLE VERSION

2.4.2

ADDITIONAL INFORMATION

This fixes #34449

@ansibot
Copy link
Contributor

ansibot commented Jan 14, 2018

cc @brunocalogero @dagwieers @schunduri
click here for bot help

@ansibot ansibot added aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 14, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Jan 15, 2018
dagwieers
dagwieers approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Jan 15, 2018
@dagwieers dagwieers merged commit 32997a5 into ansible:devel Jan 15, 2018
@ansible ansible deleted a comment from ansibot Jan 15, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.5 This issue/PR affects Ansible v2.5 cisco Cisco technologies feature This issue/PR relates to a feature request. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aci_bd: Need an option to specify a BD MAC address when dealing with BDs
3 participants
@jmcgill298 @ansibot @dagwieers