Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Elliptic Curve account keys to letsencrypt module #34852

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Add support for Elliptic Curve account keys to letsencrypt module #34852

merged 2 commits into from
Jan 16, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Adds support for Elliptic Curve account keys to the letsencrypt module. (It currently only supports RSA account keys.)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

letsencrypt

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Jan 14, 2018

cc @mgruener @resmo
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 14, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jan 15, 2018
@resmo resmo self-requested a review January 15, 2018 20:58
@resmo
Copy link
Contributor

resmo commented Jan 15, 2018 •
edited

@felixfontein Hi Felix, this looks pretty good. I don't see anything that would break backwards compatibility, do you have any doubts?

I feel like you would be a good candidate for maintaining this module. Would you be interested?

@felixfontein
Copy link
Contributor Author

@resmo Hi René, no, this shouldn't break backwards compatibility at all, so it should be safe.

@felixfontein
Copy link
Contributor Author

About maintaining this module: yes, I would be interested in helping out!

@resmo
Copy link
Contributor

resmo commented Jan 16, 2018

code lgtm.

(suggesting you as an additional maintainer)

shipit

@felixfontein
Copy link
Contributor Author

Thanks!

@resmo resmo merged commit c42c0f0 into ansible:devel Jan 16, 2018
@resmo
Copy link
Contributor

resmo commented Jan 16, 2018

Thanks!

@resmo resmo mentioned this pull request Jan 16, 2018
Merged
@felixfontein felixfontein deleted the letsencrypt-ec-key-support branch January 18, 2018 21:52
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@felixfontein felixfontein mentioned this pull request Apr 7, 2018
Merged
@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@felixfontein @ansibot @resmo @dagwieers @Akasurde