Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Refactor vmware_maintenancemode module #35000

Merged
merged 1 commit into from
Jan 18, 2018
Merged

VMware: Refactor vmware_maintenancemode module #35000

merged 1 commit into from
Jan 18, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_maintenancemode.py

ANSIBLE VERSION
2.5devel

@ansibot
Copy link
Contributor

ansibot commented Jan 17, 2018

cc @Akasurde @dav1x @jctanner @jjahns @nerzhul
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jan 17, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jan 17, 2018
@Akasurde
Copy link
Member Author

@pdellaert @tchernomax Could you please review this ?

tchernomax
tchernomax suggested changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor modification suggested, else it looks good to me.

lib/ansible/modules/cloud/vmware/vmware_maintenancemode.py Outdated

success, result = wait_for_task(task)

return self.module.exit_json(changed=success,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the return isn't necessary (you don't use it in ExitMaintenanceMode).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, missed it.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 17, 2018
@Akasurde
VMware: Refactor vmware_maintenancemode module
810aa1a 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
tchernomax
tchernomax approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 18, 2018
@ansibot ansibot merged commit cf88bfd into ansible:devel Jan 18, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
@Akasurde Akasurde deleted the vmware_maintenance_refactor branch July 13, 2021 04:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tchernomax tchernomax tchernomax approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Akasurde @ansibot @tchernomax