Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws_s3 action plugin to find source files as expected #35028

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Add aws_s3 action plugin to find source files as expected #35028

merged 1 commit into from
Jan 19, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

People expect to be able to upload files to s3 using standard
locations for files.

Providing an action plugin that effectively rewrites the src
key to the result of finding such a file is a great help.

Tests added, and IAM permissions corrected

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_s3

ANSIBLE VERSION
ansible 2.5.0 (devel 5a9562a101) last updated 2018/01/18 10:21:40 (GMT +1000)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Dec 11 2017, 14:52:53) [GCC 7.2.1 20170915 (Red Hat 7.2.1-2)]

@ansibot
Copy link
Contributor

ansibot commented Jan 18, 2018

cc @lwade @s-hertel
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 cloud feature_pull_request needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 18, 2018
Add aws_s3 action plugin to find source files as expected
29d77d2 
People expect to be able to upload files to s3 using standard
locations for files.

Providing an action plugin that effectively rewrites the `src`
key to the result of finding such a file is a great help.

Tests added, and IAM permissions corrected
@s-hertel s-hertel added aws new_plugin This PR includes a new plugin. and removed needs_triage Needs a first human triage before being processed. labels Jan 18, 2018
@s-hertel s-hertel merged commit 4d58d16 into ansible:devel Jan 19, 2018
@s-hertel
Copy link
Contributor

Thanks @willthames this is great!

@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws cloud feature This issue/PR relates to a feature request. new_plugin This PR includes a new plugin. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willthames @ansibot @s-hertel @ryansb