Win lineinfile fix

[nwsparks]

SUMMARY

Fixes #33858
Added test for this particular issue
Updated the copyright headers

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

win_lineinfile

ANSIBLE VERSION

ansible 2.5.0 (win_lineinfile_fix d5a530a351) last updated 2018/01/19 16:34:00 (GMT +000)
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/ansible/lib/ansible
  executable location = /opt/ansible/bin/ansible
  python version = 2.7.12 (default, Nov  2 2017, 19:20:38) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]

ADDITIONAL INFORMATION

win_lineinfile had a section which was converting \r\n to`r`n` which is the PowerShell method of inserting line breaks. This was causing things like some windows paths (ex. c:\return\new) to be inserted incorrectly.

After removing the section, if line breaks are desired they can still be done path: "break\r\nhere". The quoting is important.

  - name: no line break
    win_lineinfile:
      path: c:\test.txt
      line: c:\return\new

  - name: no line break
    win_lineinfile:
      path: c:\test.txt
      line: 'c:\return\new'

  - name: line break occurs
    win_lineinfile:
      path: c:\test.txt
      line: "c:\return\new"

Any conversions are occurring in Ansible prior to being processed by PowerShell. So things like path: "break`r`nhere" are interpreted literally by powershell and no line break will occur.

[ansibot]

cc @brianlloyd @dagwieers @jborean93 @jhawkesworth @nitzmahone
click here for bot help

[jborean93]

The changes seem good to me but it would be good if you could add in

• Some documentation/examples of how to create a regex with special characters like \t, e.g. PowerShell regex vs Python regex
• A test for the above to prove that it does work

I know this will probably break people's playbooks but the changes you have here is arguably what they should be doing so once we have expanded the above I'm good to merge.

[mattclay]

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/54327/9/tests

[nwsparks]

Sorry for delays, been pretty busy at work. Added documentation and some additional testing per request. LMK if you want any changes.

[jborean93]

@nwsparks sorry I hadn't looked at this earlier, looks good to me and I'll add to the 2.5 blocker list in case there is a new RC being released.

rebuild_merge

[nwsparks]

@jborean93 no problem, thanks for the review.

[jborean93]

Backport PR for the stable-2.5 release is here #36888