Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds two new infoblox lookup plugins #35189

Merged
merged 4 commits into from
Jan 24, 2018
Merged

adds two new infoblox lookup plugins #35189

merged 4 commits into from
Jan 24, 2018

Conversation

privateip
Copy link
Contributor

  • nios - lookup plugin to return nios objects to the playbook
  • nios_next_ip - lookup plugin to return the next avaiable ip address

adds two new infoblox lookup plugins
e4cd1e2 
* nios - lookup plugin to return nios objects to the playbook
* nios_next_ip - lookup plugin to return the next avaiable ip address
@ansibot
Copy link
Contributor

ansibot commented Jan 22, 2018

cc @Qalthos @ganeshrn @gundalow @kedarX @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 needs_triage Needs a first human triage before being processed. net_tools Net-tools category networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 22, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Jan 22, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 22, 2018

The test ansible-test sanity --test pep8 [?] failed with the following errors:

lib/ansible/module_utils/net_tools/nios/api.py:88:12: E111 indentation is not a multiple of four
lib/ansible/plugins/lookup/nios.py:56:161: E501 line too long (184 > 160 characters)
lib/ansible/plugins/lookup/nios.py:118:1: W391 blank line at end of file

The test ansible-test sanity --test pylint [?] failed with the following error:

lib/ansible/plugins/lookup/nios.py:118:0: trailing-newlines Trailing newlines

click here for bot help

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 22, 2018
@privateip privateip closed this Jan 22, 2018
@privateip privateip reopened this Jan 22, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 23, 2018
gundalow
gundalow requested changes Jan 23, 2018
View reviewed changes
lib/ansible/plugins/lookup/nios.py
@@ -0,0 +1,105 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to .github/BOTMETA.yml like https://github.com/ansible/ansible/pull/35179/files
Will ensure we get notified about bugs and PRs

lib/ansible/utils/module_docs_fragments/nios.py Outdated
@@ -31,35 +31,49 @@ class ModuleDocFragment(object):
description:
- Specifies the DNS host name or address for connecting to the remote
instance of NIOS WAPI over REST
- Value can also be specified using INFOBLOX_HOST environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C(INFOBLOX_HOST)

Same for other ENVs

lib/ansible/plugins/lookup/nios_next_ip.py Outdated
try:
network = terms[0]
except IndexError:
raise AnsibleError('the network must be specified')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say which network?

lib/ansible/plugins/lookup/nios_next_ip.py
for a given network CIDR
requirements:
- infoblox_client
extends_documentation_fragment: nios
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if extends_documentation_fragments: works. for lookups. I don't see it used in any other lookups

make webdocs
walk to store
buy coffee
Review docs

would confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed works fine

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 23, 2018
@gundalow gundalow mentioned this pull request Jan 23, 2018
Closed
@privateip privateip closed this Jan 23, 2018
@privateip privateip reopened this Jan 23, 2018
@privateip privateip closed this Jan 24, 2018
@privateip privateip reopened this Jan 24, 2018
@gundalow gundalow merged commit 21169b2 into ansible:devel Jan 24, 2018
@gundalow
Copy link
Contributor

Merged, CI failures not related

Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@privateip @Lujeni
adds two new infoblox lookup plugins (ansible#35189)
ca172ec 
* adds two new infoblox lookup plugins

* nios - lookup plugin to return nios objects to the playbook
* nios_next_ip - lookup plugin to return the next avaiable ip address

* adds some additional examples to nios lookup

* fix up pep8 failures

* updates in response to review comments
@gundalow gundalow added the infoblox Infoblox NIOS label Apr 25, 2018
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 botmeta This PR modifies the BOTMETA.yml and this requires special attention! infoblox Infoblox NIOS needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@privateip @ansibot @gundalow @dagwieers