win_product_facts: New module to get Windows product information #35206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So this is actually a very nice way to get product key information from systems collected centrally. Especially with systems that have been upgraded from Windows 7 or Windows 8 to Windows 10 may not have a valid Windows 10 product license key printed anywhere, it was a digital license. If you ever have to reinstall the system, you may recover the system from the recovery partition, or the original media, but cannot upgrade to Windows 10 for free. By collecting the product key, one can always reinstall your free Windows upgrade. My only question is, do we want this to be part of the default facts, as it may be considered important information. Or should we make a special **win_product_key_facts** ?
ansibot
added
affects_2.5
jborean93
reviewed
Jan 22, 2018
| ansible_os_product_id = (Get-CimInstance Win32_OperatingSystem).SerialNumber | ||
| ansible_os_product_key = Get-ProductKey | ||
| } | ||
| } |
| #!powershell | ||
| # This file is part of Ansible | ||
|
|
||
| # Copyright: (c) 2017, Dag Wieers (dagwieers) <dag@wieers.com> |
There was a problem hiding this comment.
The code originated from 2017 ;-)
There was a problem hiding this comment.
Just living the the past, gotta let it go :)
| ''' | ||
|
|
||
| EXAMPLES = r''' | ||
| - name: Set product id and product key |
There was a problem hiding this comment.
Right, depends from what perspective ;-)
nitzmahone
requested changes
Jan 22, 2018
| ''' | ||
|
|
||
| EXAMPLES = r''' | ||
| - name: Set product id and product key |
There was a problem hiding this comment.
Depends on your perspective ;-)
|
|
||
| if (-not $product_key) { | ||
| # Else try to get it from the registry instead | ||
| $data = Get-ItemPropertyValue -Path "HKLM:\Software\Microsoft\Windows NT\CurrentVersion" -Name DigitalProductId |
There was a problem hiding this comment.
What if it's not there or not in the format you're expecting?
There was a problem hiding this comment.
The if-it's-not-there is now covered. If the format is not as I expect the resulting key will be corrupted. I wouldn't expect this to be the case though.
|
|
||
| Function Get-ProductKey { | ||
| # First try to find the product key from ACPI | ||
| $product_key = (Get-CimInstance -Class SoftwareLicensingService).OA3xOriginalProductKey |
There was a problem hiding this comment.
Probably also want a -ErrorAction Continue here in case the CIM class or property is not defined (eg, Server 2008)
There was a problem hiding this comment.
But then you cannot get to the OA3xOriginalProductKey property either. So should it be a try/catch instead ?
dagwieers
force-pushed
the
win_setup-key
branch
from
65fcf23
to
c09c1f6
Compare
dagwieers
force-pushed
the
win_setup-key
branch
from
c09c1f6
to
586698d
Compare
|
So I think I covered everything, except a corrupted registry key. I don't know if that's to be expected. |
dagwieers
force-pushed
the
win_setup-key
branch
from
1ffec01
to
e93dacc
Compare
ansibot
added
test
dagwieers
force-pushed
the
win_setup-key
branch
from
72522b6
to
027a5de
Compare
jborean93
approved these changes
Jan 23, 2018
Lujeni
pushed a commit
to Lujeni/ansible
that referenced
this pull request
Feb 1, 2018
…ible#35206) * win_setup: Add Product ID and Product Key in facts So this is actually a very nice way to get product key information from systems collected centrally. Especially with systems that have been upgraded from Windows 7 or Windows 8 to Windows 10 may not have a valid Windows 10 product license key printed anywhere, it was a digital license. If you ever have to reinstall the system, you may recover the system from the recovery partition, or the original media, but cannot upgrade to Windows 10 for free. By collecting the product key, one can always reinstall your free Windows upgrade. My only question is, do we want this to be part of the default facts, as it may be considered important information. Or should we make a special **win_product_key_facts** ? * Add ACPI product key support * Add integration test * Remove Get-ProductKey function, move inline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR includes a new module that returns Windows product information, and includes product id and product key information.
ISSUE TYPE
COMPONENT NAME
win_product_facts
ANSIBLE VERSION
v2.5