Azure: added auth_source to override the source of the credentials #35213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.5
nitzmahone
requested changes
Jan 23, 2018
| @@ -49,6 +55,7 @@ | |||
| ) | |||
|
|
|||
| AZURE_CREDENTIAL_ENV_MAPPING = dict( | |||
| auth_source='AZURE_AUTH_SOURCE', | |||
There was a problem hiding this comment.
We actually probably don't want this in the CREDENTIAL_ENV_MAPPING, since that'd be kinda chicken-or-egg... Probably want to check it explicitly if the module arg isn't set, and not support it in the credfile at all.
There was a problem hiding this comment.
Might also want to rename ANSIBLE_AZURE_AUTH_SOURCE - we really should've ANSIBLE_ namespaced all those from the start. :( Just want to make sure we don't collide with something they use.
| - C(auto) will follow the default precedence of module parameters -> environment variables -> default profile in credential file | ||
| C(~/.azure/credentials). | ||
| - C(cli) will source the credentials from the Azure CLI profile. | ||
| - Can also be set vial the C(AZURE_AUTH_SOURCE) environment variable. |
ansibot
removed
the
needs_triage
ansibot
added
the
needs_revision
* tweak error messages * fix auto fallback to cli * fix import issues when azure-cli not installed
|
rebuild_merge |
|
Upstream hung creating a storage account in one of the 3.6 containers; all others passed. Merging. |
Lujeni
pushed a commit
to Lujeni/ansible
that referenced
this pull request
Feb 1, 2018
…nsible#35213) * Azure: added auth_source to override the source of the credentials * removed broken cli auth and fix some review changes * missed some more cli auth stuff that isn't required * Added cli auth back in * Added docs around cli auth * fix azure CLI auth issues * tweak error messages * fix auto fallback to cli * fix import issues when azure-cli not installed
ansibot
added
feature
yuwzho
pushed a commit
to VSChina/ansible
that referenced
this pull request
Mar 13, 2018
…nsible#35213) * Azure: added auth_source to override the source of the credentials * removed broken cli auth and fix some review changes * missed some more cli auth stuff that isn't required * Added cli auth back in * Added docs around cli auth * fix azure CLI auth issues * tweak error messages * fix auto fallback to cli * fix import issues when azure-cli not installed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Overrides the auth source for Azure credentials.
ISSUE TYPE
COMPONENT NAME
azure_rm_common
ANSIBLE VERSION