Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zabbix_host: add interface definition error checking / defaults #35366

Merged
merged 2 commits into from
Jan 27, 2018
Merged

zabbix_host: add interface definition error checking / defaults #35366

merged 2 commits into from
Jan 27, 2018

Conversation

eikef
Copy link
Contributor

@eikef eikef commented Jan 25, 2018

SUMMARY

This PR adds interface plausibility/error checking, defaults, and better usability for interfaces in zabbix_host.

Fixes #34288.

ISSUE TYPE
  • Feature Pull Request
  • Bugfix Pull Request
COMPONENT NAME

zabbix_host

ANSIBLE VERSION

2.5.0

@ansibot
Copy link
Contributor

ansibot commented Jan 25, 2018

cc @D3DeFi @cove @harrisongu
click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 25, 2018
@s-hertel s-hertel added bugfix_pull_request and removed needs_triage Needs a first human triage before being processed. labels Jan 26, 2018
D3DeFi
D3DeFi approved these changes Jan 27, 2018
View reviewed changes
Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot test it but looks good :)

@D3DeFi
Copy link
Contributor

D3DeFi commented Jan 27, 2018

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 27, 2018
@ansibot ansibot merged commit eeeea14 into ansible:devel Jan 27, 2018
@eikef eikef deleted the zabbix_host_interface_checks branch January 31, 2018 13:19
Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@eikef @Lujeni
zabbix_host: add interface definition error checking / defaults (ansi…
4650ea8 
…ble#35366)

* add checking of interfaces, providing defaults or errors if required keys are not defined

* fix so that iteration of interfaces only happens if defined
@ansibot ansibot added feature This issue/PR relates to a feature request. bug This issue/PR relates to a bug. and removed feature_pull_request labels Mar 5, 2018
@dagwieers dagwieers added the zabbix Zabbix community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@D3DeFi D3DeFi D3DeFi approved these changes

Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid params. Incorrect argument passed to function while sending
5 participants
@eikef @ansibot @D3DeFi @dagwieers @s-hertel