Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Fix dvs idempotency issue #35389

Merged
merged 1 commit into from
Jan 26, 2018
Merged

VMware: Fix dvs idempotency issue #35389

merged 1 commit into from
Jan 26, 2018

Conversation

Akasurde
Copy link
Member

SUMMARY

Fixes: #35354

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_guest.py

ANSIBLE VERSION
2.5devel

@Akasurde
VMware: Fix dvs idempotency issue
4ed2c01 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Jan 26, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 26, 2018

cc @Akasurde @dagwieers @dav1x @jctanner @nerzhul @pdellaert
click here for bot help

@ansibot ansibot added bugfix_pull_request cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jan 26, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jan 26, 2018
@Akasurde
Copy link
Member Author

Akasurde commented Jan 26, 2018 •
edited

@cvanniekerk @pdellaert @tchernomax Could you please take a look ?

@Akasurde
Copy link
Member Author

@cvanniekerk Thanks. I will wait for one more approval before merge.

tchernomax
tchernomax approved these changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 26, 2018
@ansibot ansibot merged commit c96bad4 into ansible:devel Jan 26, 2018
Lujeni pushed a commit to Lujeni/ansible that referenced this pull request Feb 1, 2018
@Akasurde @Lujeni
VMware: Fix dvs idempotency issue (ansible#35389)
c80b6a4 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
@Akasurde Akasurde deleted the dvs_regression_fix branch July 17, 2019 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tchernomax tchernomax tchernomax approved these changes

Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible device backing specified for device
3 participants
@Akasurde @ansibot @tchernomax