Fix double prompt issue in network_cli #35439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#33993 In current implementation while trying to fetch the current cli prompt terminal plugin executes `\r` on remote host. This causes if command execution results in a prompt for example executing `enable` command results in `Password:` prompt there by executing `\r` on password prompt which is not intended. To fix it while fetching current prompt from terminal plugin use `get_prompt()` api in network_cli that returns the latest matched prompt instead of unnecessary executing `\r` on remote host.
ansibot
added
bugfix_pull_request
needs_triage
trishnaguha
added
networking
trishnaguha
approved these changes
Jan 29, 2018
Qalthos
approved these changes
Jan 30, 2018
Lujeni
pushed a commit
to Lujeni/ansible
that referenced
this pull request
Feb 1, 2018
Fixes ansible#33993 In current implementation while trying to fetch the current cli prompt terminal plugin executes `\r` on remote host. This causes if command execution results in a prompt for example executing `enable` command results in `Password:` prompt there by executing `\r` on password prompt which is not intended. To fix it while fetching current prompt from terminal plugin use `get_prompt()` api in network_cli that returns the latest matched prompt instead of unnecessary executing `\r` on remote host.
ansibot
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #33993
In current implementation, while trying to fetch the
current cli prompt terminal plugin executes
\ron the remote host.If command execution results in a prompt for
example executing
enablecommand results inPassword:prompt.This results in prompt and answer getting out of sync.
To fix it while fetching current prompt from terminal plugin use
get_prompt()api in network_cli that returns the latest matched cli prompt instead of executing
\ron the remote host.ISSUE TYPE
COMPONENT NAME
network_cli
ANSIBLE VERSION
ADDITIONAL INFORMATION