get_url should accept headers as a dict, instead of only a complicated string #35470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
core_review
Akasurde
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
added
needs_rebase
ansibot
added
feature
sivel
force-pushed
the
get-url-headers-dict
branch
from
77072b6
to
1fde81c
Compare
ansibot
added
core_review
ansibot
added
the
stale_ci
ansibot
added
needs_revision
mattclay
requested changes
Apr 10, 2018
| except Exception: | ||
| module.fail_json(msg="The header parameter requires a key:value,key:value syntax to be properly parsed.") | ||
| module.fail_json(msg="The string representation for the `headers` parameter requires a key:value,key:value syntax to be properly parsed.") |
There was a problem hiding this comment.
Could you include an integration test for the parsing failure? I know it's not a new code path, but it should be tested.
There was a problem hiding this comment.
New integration test added for this parsing error.
ansibot
added
needs_revision
mattclay
approved these changes
Apr 10, 2018
ansibot
added
core_review
…at was added in to description
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
…d string (ansible#35470) * get_url should accept headers as a dict, instead of only a complicated string * update headers description text * Add headers string and dict tests for get_url * Add intg test for string header format parsing error * Adjust deprecation version ahead 1 release, add the version dict format was added in to description
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
get_url should accept headers as a dict, instead of only a complicated string
This also allows for headers that may use
,s to separate values like:As of now, the above is impossible.
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/net_tools/basics/get_url.py
ANSIBLE VERSION
ADDITIONAL INFORMATION